fix(agent): don't duplicate cointerface_enabled field in deployment agent configmaps
#1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavimo
approved these changes
Aug 21, 2023
mavimo
approved these changes
Aug 21, 2023
… agent configmaps The value `cointerface_enabled: true` is hardcoded into the deployment agent's configmap by design, but if the value were overridden in `sysdig.settings` the field would end up being duplicated when the deployment configmap blindly rendered out that block. This fix addresses that issue by omitting that key when rendering the set of values from the `sysdig.settings` block.
aroberts87
force-pushed
the
fix/cointerface_enabled_duplication
branch
from
9413b74
to
4e9fefa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The value
cointerface_enabled: trueis hardcoded into the deployment agent's configmap by design, but if the value were overridden insysdig.settingsthe field would end up being duplicated when the deployment configmap blindly rendered out that block. This fix addresses that issue by omitting that key when rendering the set of values from thesysdig.settingsblock.Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
Check Contribution guidelines in README.md for more insight.